Samuele Musiani samu
  • Telling computers what to do

  • Joined on 2023-11-25
samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

This file is never used

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

Do we need to export this func? We don't use it anywhere outside this file

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

Do we really need this trick to call the script itself? Could we just use a simple main()?

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

We could add ../ at _dirname as we add it on every part of the code on this page

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

It's longer but for path normalization should be better to use:

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

Also here we don't need a custom parser, we could use https://www.npmjs.com/package/gray-matter

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

The OG images are placed in /public/og, but after that no ones read them or interact with them. They are also not present in the build files after pnpm run build, so they don't work :)

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

Do we need to export this func? We don't use it anywhere outside this file

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

We don't need the last two matching strings, only the first one

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

Do we need the license in the repo?

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

isMobile is never used :)

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

I would also add Home, even though you could reach it by clicking the logo

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

Same story of HomeView for the parser and sanitize

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

An icon looks better :)

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

What's the point of this? The exclusion should be server-side with the python script, not client side

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

We only this onces in the html, why use a compute?

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

All of this is very ugly tbh. Can we do it at compile time like the og photos?

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

All the logic in this file is a bit meh. But maybe with markdown render generation at compile time could be better

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

We can fall back to English, I think it's better. But we could also check the browser language (with navigator.language i think) and use that if it falls in the [it, en] set.

samu commented on pull request adm/website#6 2026-04-20 08:46:40 +00:00
New Website in VueJS

We don't need a custom parser. There are already made parsers for the frontmatter, like: https://www.npmjs.com/package/gray-matter